[BD-13] depr: deprecated the user_id attribute - #542
Conversation
|
Thanks for the pull request, @pomegranited! I've created BLENDED-940 to keep track of it in Jira. More details are on the BD-13 project page. When this pull request is ready, tag your edX technical lead. |
openedx-webhooks
added
blended
symbolist
left a comment
symbolist
left a comment
There was a problem hiding this comment.
I have tested this as part of https://github.com/edx/edx-platform/pull/28440. Good to go. 👍🏽
|
@pomegranited Can you rebase this? I'll merge once it is green. |
21db3b2 to
e50ca15
Compare
|
@pomegranited Just realized we missed bumping up the version number and adding a changelog entry. 🙂 |
This value should be fetched from the 'user' service.
e50ca15 to
71de7d0
Compare
|
@symbolist Oops, thank you for catching that! I've bumped the version to 1.5.1, added a CHANGELOG entry, and squashed my commits back down to 1. |
|
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
3 participants
Description
The user_id should be fetched from the 'user' service, not stored in the Runtime.
This change should not affect Learners, Course Authors, or anyone else using edx-platform.
Supporting information
Testing instructions
See https://github.com/edx/edx-platform/pull/28440 for testing instructions and sandbox.
Deadline
None
Other information